Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-2508: Remove sorting functionality in biometrics table #1425

Merged
merged 3 commits into from
Oct 21, 2023
Merged

(fix) O3-2508: Remove sorting functionality in biometrics table #1425

merged 3 commits into from
Oct 21, 2023

Conversation

mccarthyaaron
Copy link
Contributor

@mccarthyaaron mccarthyaaron commented Oct 21, 2023 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR removes sorting functionality from the Biometrics table such that none of the table headers can be used to sort the biometrics

Screenshots

Untitled.video.-.Made.with.Clipchamp.mp4

Related Issue

TICKET: https://issues.openmrs.org/browse/O3-2508

denniskigen
denniskigen approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mccarthyaaron!

@denniskigen denniskigen merged commit b9dae5a into openmrs:main Oct 21, 2023
6 checks passed
@mccarthyaaron mccarthyaaron deleted the remove-sorting branch February 3, 2024 21:16
@mccarthyaaron mccarthyaaron restored the remove-sorting branch February 3, 2024 21:16
@mccarthyaaron mccarthyaaron deleted the remove-sorting branch February 3, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccarthyaaron @denniskigen