(feat) Highlight abnormal values in vitals and biometrics form #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadijahkyampeire
requested review from
denniskigen,
brandones,
FlorianRappl and
ibacher
|
Size Change: +1.33 kB (0%) Total Size: 9.12 MB
ℹ️ View Unchanged
|
denniskigen
changed the title
denniskigen
changed the title
denniskigen
changed the title
hadijahkyampeire
force-pushed
the
hk-o3-2499
branch
from
b5596e7 to
f6d7fde
Compare
ibacher
requested changes
Oct 23, 2023
...ges/esm-patient-vitals-app/src/vitals/vitals-biometrics-form/vitals-biometrics-form.utils.ts
Show resolved
Hide resolved
...m-patient-vitals-app/src/vitals/vitals-biometrics-form/vitals-biometrics-input.component.tsx
Outdated
Show resolved
Hide resolved
...m-patient-vitals-app/src/vitals/vitals-biometrics-form/vitals-biometrics-input.component.tsx
Outdated
Show resolved
Hide resolved
...m-patient-vitals-app/src/vitals/vitals-biometrics-form/vitals-biometrics-input.component.tsx
Outdated
Show resolved
Hide resolved
|
@hadijahkyampeire, here's some context about error messages after talking to Ciaran about it:
|
|
Is the plan to try and include this in the 3.0.0-beta.14 release? |
That release already exists, so no 😁. We can include it in the next |
|
Roger that, thanks Ian :) OK I have tagged the source Jira Tickets with "Fix Version: 3.0.0-beta.15" so that it shows up on our "stuff to release next time" list here: https://issues.openmrs.org/projects/O3/versions/34001 |
|
Thanks @denniskigen this is so helpful |
hadijahkyampeire
force-pushed
the
hk-o3-2499
branch
from
f478c40 to
48d3060
Compare
|
@ibacher @denniskigen I have worked on all the feedback and attached an updated recording, please take another look. Thanks. |
denniskigen
force-pushed
the
hk-o3-2499
branch
from
2038f69 to
caf1bd7
Compare
|
State of things following the latest commits:
|
denniskigen
force-pushed
the
hk-o3-2499
branch
2 times, most recently
from
e0c1e27 to
0a612a6
Compare
|
Ciaran's feedback:
vitals-form-validation.mp4 |
denniskigen
force-pushed
the
hk-o3-2499
branch
from
0a612a6 to
fa6a890
Compare
ibacher
reviewed
Oct 31, 2023
| @@ -89,17 +94,24 @@ const VitalsBiometricInput: React.FC<VitalsBiometricInputProps> = ({ | |||
| const showInvalidInputError = showErrorMessage && isInvalidInput; | |||
| const errorMessageClass = showInvalidInputError ? styles.invalidInput : ''; | |||
|
|
|||
| const containerClasses = classNames(styles.inputContainer, { | |||
There was a problem hiding this comment.
I keep forgetting about this library. We should use it more often!
|
Thanks @denniskigen for the commits. @ibacher please take another look whenever you get a chance, Thanks. |
denniskigen
force-pushed
the
hk-o3-2499
branch
from
bf649dd to
5239599
Compare
|
State of things following the latest commits:
vitals-form-validation.mp4There's still one gnarly bug to deal with - it involves fixing an issue where the validation gets triggered even when the input is cleared, i.e. If you delete the contents of the already validated input, the validation still gets triggered with the empty value. |
- Biometrics input should be readOnly, not disabled - Abnormal value feedback should be triggered when we remove focus from a field - Use classnames library to clean up conditional classnames
- Make the BMI input readonly - Reorder inputs to match designs - Update tests
denniskigen
force-pushed
the
hk-o3-2499
branch
from
445e9ec to
c3e1765
Compare
denniskigen
force-pushed
the
hk-o3-2499
branch
from
c3e1765 to
79557eb
Compare
|
Current state of things: vitals-biometrics-form-latest.mp4 |
ibacher
previously approved these changes
Nov 3, 2023
denniskigen
previously approved these changes
Nov 3, 2023
denniskigen
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
invalidinputRelevant design doc
Screenshots
vital-inputs-states.mov
Related Issues
Abnormal values should get flagged with a different background color
Highlight abnormal values in vitals inputs using arrows