BREAKING: Merge vitals and biometrics apps #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
requested review from
denniskigen,
donaldkibet,
vasharma05 and
icrc-jofrancisco
Essentially, this merges the biometrics app into the vitals app. There isn't really a strong reason to separate them and their implementation details already had enough overlap that we were effectively requiring the same configuration settings to be set for both apps. Finally, its cleaner to get everything to work with SWR caching if certain implementation details are shared, so I've collapsed them into a single application.
ibacher
force-pushed
the
breaking/vitals-and-biometrics-urls
branch
from
8797cbc to
ba5b1fe
Compare
|
Size Change: -758 kB (-8%) ✅ Total Size: 8.65 MB
ℹ️ View Unchanged
|
|
Hi @ibacher, question about this work: What would be the implications of this for sites that don't actually want the biometrics app to show up everywhere the Vitals app does? E.g. IIRC at some sites, like Ampath, they wanted the VS chart on the pt summary, but not the Biometrics table. Do implementers lose that configurability? |
No. They have the same configurability options. The biometrics table can easily be removed using the config system, which remains our preferred mechanism for implementations to opt out of functionality. (As long as the biometrics table is configured to not show, there's no substantive performance impact to having the bundle avaiable). |
|
@denniskigen I'd appreciate a review here when you get the chance. I'd like to get this in before replacing the |
denniskigen
approved these changes
Nov 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Essentially, this merges the biometrics app into the vitals app. The main motivation is to clean-up the shared configurations and SWR caching.
Screenshots
Related Issue
Other