(feat) Supporting O3-2510: Expose patient-common-lib on window #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +30 B (0%) Total Size: 9.1 MB ℹ️ View Unchanged
|
|
Question on the premise here: openmrs-ngx-formentry is, in fact, using Webpack (I realize the Angular team regards this as an "implementation detail", but it's one we rely on). With that in mind, do you think this is still the right approach or should we use something like |
|
Oh, interesting. I guess I am still inclined to do it this way. I don't think it poses major disadvantages, other than that there's no way to do explicit version dependency, and this can be substituted for checking expected function signatures and logging good error messages. I'm not sure it would be worth it to get the whole |
3 tasks
ibacher
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Makes esm-patient-common-lib available on the window object. This will allow ngx-formentry to access it despite not being a webpack module.
Related Issue
https://issues.openmrs.org/browse/O3-2510
Other
Copilot called me out for doing a hack
