-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3 Modal confirmation from user to modify visit date to accomodate new encounter date and time #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -484 kB (-4%) Total Size: 10.7 MB
ℹ️ View Unchanged
|
vasharma05
force-pushed
the
feat/retrospective-form-edit
branch
from
November 16, 2023 18:51
46bccdc
to
b85f54f
Compare
vasharma05
changed the title
(feat) Allow editing forms in retrospective data entry
(fix) Bypassing the user confirmation for extending visit dates when editing a past encounter
Nov 16, 2023
… date and use O3 confirmation modal
vasharma05
changed the title
(fix) Bypassing the user confirmation for extending visit dates when editing a past encounter
(fix) O3 Modal confirmation from user to modify visit date to accomodate new encounter date and time
Nov 16, 2023
ibacher
approved these changes
Nov 16, 2023
Thanks @vasharma05! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Currently, whenever the user tries to save a form saved in a previous visit, the user is asked for a confirmation to extend visit dates to accommodate the new visit date.
The confirmation was via the browser's
confirm
API, which is replaced by the O3 Carbon Design modal. Alongside, the validation for encounter date time happens even before the submission process is initiated.Screenshots
Screen.Recording.2023-11-17.at.01.47.45.mov
Related Issue
Other