-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BREAKING) Update i18next interpolation syntax #1439
Merged
denniskigen
merged 3 commits into
main
from
breaking/using-i18next-default-configuration
Oct 28, 2023
Merged
(BREAKING) Update i18next interpolation syntax #1439
denniskigen
merged 3 commits into
main
from
breaking/using-i18next-default-configuration
Oct 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default interpolation
Size Change: -39 kB (0%) Total Size: 9.11 MB
ℹ️ View Unchanged
|
denniskigen
changed the title
(BREAKING) Updated the variables in the translations files according to i18next default configuration
(BREAKING) Update i18next interpolation syntax
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
reviewed
Oct 27, 2023
denniskigen
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a bunch, @vasharma05.
denniskigen
added a commit
to CynthiaKamau/openmrs-esm-patient-chart
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR is a child PR of openmrs/openmrs-esm-core#799.
Notable changes in translations:
{{
and}}
instead of{
and}
.count
variable to leverage the pluralization support.Screenshots
Dev3 after merging openmrs/openmrs-esm-core#799 but without this PR
These changes along with changes in Dev3
Related Issue
None
Other
This PR also includes update to the translation for the pagination component in the common-lib.