-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-2531: Enhance form control sizing for improved UX in tablet mode #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
changed the title
(enhc) Form entry
(enhc) O3-2531-Enhance form control sizing for improved UX in tablet mode
Oct 29, 2023
save and close
and close
button UI enhancement
denniskigen
changed the title
(enhc) O3-2531-Enhance form control sizing for improved UX in tablet mode
(feat) O3-2531: Enhance form control sizing for improved UX in tablet mode
Oct 30, 2023
denniskigen
force-pushed
the
enhc/formUI
branch
from
October 30, 2023 17:37
7995695
to
16f7c3e
Compare
Size Change: -484 kB (-5%) ✅ Total Size: 9.11 MB
ℹ️ View Unchanged
|
denniskigen
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @donaldkibet.
denniskigen
added a commit
to CynthiaKamau/openmrs-esm-patient-chart
that referenced
this pull request
Oct 31, 2023
… mode (openmrs#1440) Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR updates the form action buttons to match the available design. Prior to this change, the
Save and close
andDiscard
buttons were rendered at the bottom of the workspace. Following this change, the action buttons now get rendered below the form page tabs UI on the left-hand side of the UI.Screenshots
Kapture.2023-10-29.at.13.09.07.mp4
Related Issue
Other