-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) Use classNames to apply classes conditionally #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
refactor/classnames
branch
from
November 4, 2023 20:00
58276a1
to
bae0313
Compare
Size Change: -6.09 kB (0%) Total Size: 9.12 MB ℹ️ View Unchanged
|
denniskigen
changed the title
(refactor) Use classNames for conditional classes
(refactor) Use classNames to apply classes conditionally
Nov 4, 2023
denniskigen
force-pushed
the
refactor/classnames
branch
from
November 4, 2023 20:45
eab607a
to
8a74d84
Compare
ibacher
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR refactors code in this repository to leverage the classNames library for applying classes conditionally. This should make the code more readable and easier to maintain.
Screenshots
None
Related Issue
None
Other
None