Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix error when clearing the test type field of the lab order form #1460

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

makombe
Copy link
Contributor

@makombe makombe commented Nov 10, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Before

before

After

after

Related Issue

None

Other

None

@denniskigen
Copy link
Member

denniskigen commented Nov 10, 2023

Hey, @makombe, I've pushed a couple other commits to your PR that do the following:

  • Rename the LabOrderForm component to use the .component suffix. This is so that it gets added to the list of files that i18next-parser extracts translation strings from.
  • Owing to the change made above, updating translations for the lab order form.
  • Committing some orphaned changes to translations in the forms app.

@denniskigen denniskigen changed the title (fix): Fix error when removing lab test type from input field (fix) Fix error when clearing the test type field of the lab order form Nov 10, 2023
@denniskigen denniskigen merged commit e53014c into openmrs:main Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants