Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Register forms endpoint as dynamic route #1470

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

icrc-jofrancisco
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This pull request addresses the need to enhance offline availability by registering forms routes as dynamic routes within the service worker.

I have added the necessary modifications to register forms routes dynamically, allowing the service worker to cache these routes and make them accessible even when the user is offline. This improvement ensures a seamless user experience by enabling the application to function offline when interacting with forms.

Screenshots

Related Issue

Other

Thanks,

CC: @ibacher

@ibacher ibacher changed the title (chore) Register forms endpoint as dynamic route (fix) Register forms endpoint as dynamic route Nov 16, 2023
@ibacher
Copy link
Member

ibacher commented Nov 16, 2023

@icrc-jofrancisco Shouldn't we also register the o3forms endpoint? It would probably be good to do that in this PR as well.

@icrc-jofrancisco
Copy link
Contributor Author

@icrc-jofrancisco Shouldn't we also register the o3forms endpoint? It would probably be good to do that in this PR as well.

Yes. Done! Thanks

@ibacher ibacher merged commit 9a472fb into openmrs:main Nov 16, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants