Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)O3 2570: Use the new snackbar in patient chart(6 apps) #1478

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

jona42-ui
Copy link
Contributor

@jona42-ui jona42-ui commented Nov 20, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Added snackbar in the form-entry-app, patient-allergy, patient-appointment, patient-attachmnets-app, patient-chat-app, patient-flags

Screenshot for attachments-app

Screenshot from 2023-11-20 17-37-33

Related Issue

https://issues.openmrs.org/browse/O3-2570

Other

title: 'Program enrollment',
description: 'Patient has been enrolled successfully',
subtitle: 'Patient has been enrolled successfully',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jona42-ui how was this success message before the change, was it appearing with high contrast(black background)? Because we might need to change it to a low contrast(green background) since the designs expect success messages to be green. cc @denniskigen how should this be handled?

Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @jona42-ui , just a minor concern please confirm that the toast message I commented on was using high contrast before or not, and then do the appropriate implementation.

@jona42-ui
Copy link
Contributor Author

This looks good, thanks @jona42-ui , just a minor concern please confirm that the toast message I commented on was using high contrast before or not, and then do the appropriate implementation.

cool!

@hadijahkyampeire hadijahkyampeire merged commit 8b6b72b into openmrs:main Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants