-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat)O3 2570: Use the new snackbar in patient chart(6 apps) #1478
Conversation
title: 'Program enrollment', | ||
description: 'Patient has been enrolled successfully', | ||
subtitle: 'Patient has been enrolled successfully', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jona42-ui how was this success message before the change, was it appearing with high contrast(black background)? Because we might need to change it to a low contrast(green background) since the designs expect success messages to be green. cc @denniskigen how should this be handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @jona42-ui , just a minor concern please confirm that the toast message I commented on was using high contrast before or not, and then do the appropriate implementation.
cool! |
Requirements
Summary
Added snackbar in the
form-entry-app
,patient-allergy
,patient-appointment
,patient-attachmnets-app
,patient-chat-app
,patient-flags
Screenshot for attachments-app
Related Issue
https://issues.openmrs.org/browse/O3-2570
Other