(feat) Order basket UI tweaks #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it preferable to just omit the medications details when they're not available instead of showing these empty dashes, @gracepotma @ibacher? |
|
Size Change: +1.04 kB (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
|
@denniskigen My vote is for yes. With the caveat that I'd probably try to ensure that there's an em-dash between, e.g., DOSE and REFILLS. |
ibacher
approved these changes
Nov 20, 2023
|
This is how things look with the change:
|
|
That looks right to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR applies several tweaks to the order basket to get the UI elements to conform to new designs for the order basket header and order items.
Screenshots
Before
After
Related Issue
Other