-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Allow edit O2 form in visits widget #1489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I think the PR is fine. However, I don't love having lauchFormEntryOrHtmlForms()
defined in two places. I think the thing to do is to move that function from esm-forms-app into the patient-common-lib and then re-use the same function here with a small adapter for handling the MappedEncounter
.
The logic for the editPage should look a lot like the logic for the new form page, so we might need to modify some other places. I'd expect it to be populated as ${htmlForm.formEditUiPage}
or something similar. This is because HFE itself supports multiple different edit pages depending on the use-case.
…esm-patient-chart into fix/o2-edit-encounter
Requirements
Summary
This pull request addresses an issue where clicking "Edit this Encounter" always opened a new form instead of allowing users to edit the existing O2 form within the visits widget. The modification ensures a more intuitive and efficient workflow by enabling the direct editing of O2 forms.
Screenshots
Related Issue
Other
Thanks,
CC: @ibacher