(feat) Tweak aspects of the patient lists workspace #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested review from
jayasanka-sack,
hadijahkyampeire and
CynthiaKamau
Comment on lines
29
to
30
| console.log('workspaces: ', workspaces); | ||
| console.log('workspaceWindowState: ', workspaceWindowState); |
There was a problem hiding this comment.
Suggested change
| console.log('workspaces: ', workspaces); | |
| console.log('workspaceWindowState: ', workspaceWindowState); |
There was a problem hiding this comment.
Yikes, eslint should have caught that.
There was a problem hiding this comment.
I know, right? Do you have an idea why it didn't?
There was a problem hiding this comment.
Yep, looks like that rule wasn't enabled. Working on a PR to fix that now.
|
Size Change: -202 B (0%) Total Size: 10.3 MB ℹ️ View Unchanged
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
These tweaks include:
canHideprop to false). Having a close button is useful because this workspace doesn't have action buttons at the bottom of the screen.typeof the summary and detail views to thepatient-listsso that both workspaces can take advantage of the built-in side rail / bottom nav highlighting functionality for active workspaces.Screenshots
Related Issue
None
Other
None