-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) Remove async waitFor from tests #1500
Conversation
Size Change: +72 B (0%) Total Size: 10.3 MB ℹ️ View Unchanged
|
5e3cd9e
to
8b9a17f
Compare
8b9a17f
to
a821f9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @denniskigen! I suspect this could be a result of repeatedly copying and pasting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denniskigen
Merge at will
It seems one of the unit tests is failing, could you please chek? |
Thanks! |
Requirements
Summary
Removes the @testing-library/react waitFor function from unit tests. Most invocations of waitFor in our unit tests are unnecessary. Consider the following example:
Because we're already awaiting the click event, the
waitFor
in this instance is superfluous. Additionally, becausewaitFor
imposes a default timeout, having many invocations of it in our test suite is likely why running tests often fails due to timeouts.Screenshots
None
Related Issue
None
Other
None