Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-2571: Use new snackbar notification in conditions, notes, orders and vitals apps #1502

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

njiddasalifu
Copy link
Contributor

@njiddasalifu njiddasalifu commented Nov 24, 2023

Requirements

Summary

Using the new snackbar in the O3 apps. This is archieved by replacing toasts toasts to snackbar.

Screenshots

Screenshot from 2023-11-23 19-27-06

Related Issue

https://issues.openmrs.org/browse/O3-2571

Copy link
Contributor Author

@njiddasalifu njiddasalifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @hadijahkyampeire review this one. The former is closed due some conflicting files. Here the conflicts are resolved.
Reason why many files seems changed.

@njiddasalifu njiddasalifu changed the title (feat): O3-2571: Use the new snackbar in conditions and visites apps (feat): O3-2571: Using the new snackbar in conditions and visites apps Nov 24, 2023
@denniskigen denniskigen changed the title (feat): O3-2571: Using the new snackbar in conditions and visites apps (feat): O3-2571: Use new snackbar notification in conditions, notes, orders and vitals apps Nov 24, 2023
@denniskigen denniskigen changed the title (feat): O3-2571: Use new snackbar notification in conditions, notes, orders and vitals apps (feat) O3-2571: Use new snackbar notification in conditions, notes, orders and vitals apps Nov 24, 2023
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @njiddasalifu!

@denniskigen denniskigen merged commit 0ec7d19 into openmrs:main Nov 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants