(fix) Missing translations in forms workspace title and vitals overview component #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
requested review from
denniskigen and
ibacher
and removed request for
denniskigen
|
Size Change: +12 B (0%) Total Size: 10.3 MB ℹ️ View Unchanged
|
|
Hi @ibacher , can you please review the changes? |
denniskigen
force-pushed
the
fix/vitals-forms-missing-translations
branch
from
6809e27 to
36acc40
Compare
ibacher
reviewed
Nov 29, 2023
| @@ -45,7 +45,7 @@ test('Record vital signs', async ({ page, api }) => { | |||
|
|
|||
| await test.step('And I should see the newly recorded vital signs on the page', async () => { | |||
| await expect(headerRow).toContainText(/temp/i); | |||
| await expect(headerRow).toContainText(/bp/i); | |||
| await expect(headerRow).toContainText(/blood pressure/i); | |||
There was a problem hiding this comment.
I'm a little confused about why this works... Doesn't the header row still say BP?
|
This is a good work around for now. Longer term:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds the missing translations for:
The key used in the translation files is
clinicalForms, and the key used in the workspace extension isclinicalForm.Screenshots
Before
After
Related Issue
Other