(fix) Fix rendering error in conditions form #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +47 B (0%) Total Size: 10.3 MB ℹ️ View Unchanged
|
|
LGTM! |
ibacher
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Fixes an issue where clicking outside the searchbox in the Conditions form would cause the whole form component to crash. AFAICT, providing an empty string as the defaultValue for the input seems to fix the immediate issue. Worryingly, it looks as though validation is completely broken. I'm not entirely sure why this is the case, and whether this regression is limited to just this form or whether its a more widespread issue.
Tangentially, I've also added debounced search capabilities to the search input which should delay firing requests by the default 500ms interval as the user types into the input.
Video
conditions.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-2603
Other