(fix) O3-2666: Order getting removed after clicking on Back to order basket

[usamaidrsk]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

• Fix Order getting removed after clicking on Back to order basket

Screenshots

Related Issue

O3-2666

Other

[brandones]

Hi Usama! Thanks for the PR. A note on how we handle PRs.

The checkboxes are there both to remind the submitter to do stuff and to communicate with others. You should not check them if they are not relevant. The one about conforming to the styleguide informs the reviewer that you have done some design implementation that references some specific designs. That isn't relevant to this ticket, so don't check the box. The one about tests requires some careful thought; the question is whether tests would fail if you didn't make the change you made. Tests were passing before (with the bad behavior), and you have only removed tests; therefore it is impossible that if your change was somehow undone that tests would fail. Therefore your change is not tested for, and you shouldn't check the box. It's not strictly a requirement, but if it's not too hard to write a test that protects us against this bug, it would be great to have.

[usamaidrsk]

Hi Usama! Thanks for the PR. A note on how we handle PRs.

The checkboxes are there both to remind the submitter to do stuff and to communicate with others. You should not check them if they are not relevant. The one about conforming to the styleguide informs the reviewer that you have done some design implementation that references some specific designs. That isn't relevant to this ticket, so don't check the box. The one about tests requires some careful thought; the question is whether tests would fail if you didn't make the change you made. Tests were passing before (with the bad behavior), and you have only removed tests; therefore it is impossible that if your change was somehow undone that tests would fail. Therefore your change is not tested for, and you shouldn't check the box. It's not strictly a requirement, but if it's not too hard to write a test that protects us against this bug, it would be great to have.

Thanks @brandones, It's a good guide, and I will endeavor to follow along. Also with the tests I am to add the tests as to the changes I made.

[brandones]

LGTM, thanks @usamaidrsk & @vasharma05