(fix) O3-2671: Lab orders added directly to the basket should be marked incomplete #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnasambu
force-pushed
the
(fix)O3-2671
branch
from
544f3b8 to
25c1cd5
Compare
There was a problem hiding this comment.
Looks Good @jwnasambu. For Build, I suggest you try running individual packages tests locally and see if they can all pass it will be easy to debug then.
denniskigen
changed the title
denniskigen
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
I've made the status tag for lab order items dynamic based on whether the order is complete or incomplete (based on
orderBasketItem.isOrderIncomplete). If the order is incomplete, anIncompletestatus tag gets rendered. Existing functionality for marking complete orders with aNewstatus tag is maintained.Design documentation for Order items https://zeroheight.com/23a080e38/p/030b9a-order-item
Screenshots
screencast.2023-12-20.12.AM-14-04.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-2671
Other