(fix) O3-2718: inconsistent notification style upon cancelling an active visit #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psworld
changed the title
hadijahkyampeire
approved these changes
Jan 8, 2024
brandones
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ive visit (#1566) O3-2718: Fix inconsistent notification style upon cancelling an active visit Co-authored-by: Ps <[email protected]> Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
When an Active Visit is cancelled the notification is an
ActionableNotification. This issue on JIRA states that the notification on cancelling an active visit should not be anActionableNotificationbut instead should be a simpleSnackbar, which is consistent with styling of rest of app.This PR fixes the above issue.
I have fixed the tests where was required. Currently all tests pass.
Screenshots
Before
After
Related Issue
Link to JIRA ticket: https://openmrs.atlassian.net/browse/O3-2718