(fix) O3-2719: Inconsistent UI in visit summaries tabs when Empty State #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denniskigen Hello sir, Thankyou for your time and consideration 🙏 |
Thankyou so much Sir 🙏🙏🙏❤️ |
brandones
pushed a commit
that referenced
this pull request
Jan 11, 2024
…te (#1567) (fix) O3-2719: Inconsistent UI in visit summaries tabs Co-authored-by: Ps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Inconsistent styles are present in Visit summaries tabs when Empty state is present. e.g Empty state for Notes tab is a simple text saying
No notes foundwhile for Tests tab it's a styled<EmptyState />component.In this PR I have changed all of the empty state of tabs to the
<EmptyState />component so that the style is consistent.I have also modified tests accordingly
Screenshots
Before
After
Related Issue
Link to JIRA ticket: https://openmrs.atlassian.net/browse/O3-2719