(refactor) Set global testTimeout in Jest config #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -110 B (0%) Total Size: 10.3 MB ℹ️ View Unchanged
|
ibacher
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
It looks like the highest value that's being replaced here is 20000, so maybe we could try that?
Since Jest is used for unit tests, anything that's taking longer than 5000ms, IMO is either a broken test (i.e., it's executing more code than it should) or indicates that the production code is way to slow (I guess it's also possible that it means that too many tests are being executed in parallel).
|
It also seems to work perfectly with 10000ms. |
3 tasks
denniskigen
force-pushed
the
refactor/test-timeouts
branch
from
e039493 to
94f3bca
Compare
|
Thanks for the suggestions. I'm inclined to try out a |
3 tasks
brandones
pushed a commit
that referenced
this pull request
Jan 11, 2024
* (refactor) Set global testTimeout in Jest config * Commit some orphaned translations * Lower global timeout to 20000ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR removes test timeouts from individual tests and moves them up into the global Jest config as a single
testTimeoutproperty whose value is set to20000ms. Hopefully this tackles the issue where tests time out non-deterministically.20000ms seems like a reasonable value, though it'd be worthwhile trying to lower this figure down as we move along so we strike a good balance with a value that's not too low to prematurely terminate valid long-running tests, and not too high to unnecessarily prolong the feedback loop for test failures.
Screenshots
None
Related Issue
None
Other
None