Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Restrict attachments to configured allowed extensions #1584

Merged
merged 16 commits into from
Jan 30, 2024
Merged

(feat) Restrict attachments to configured allowed extensions #1584

merged 16 commits into from
Jan 30, 2024

Conversation

icrc-loliveira
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR created a new configuration 'allowedExtensions' that allow filter by the extensions that can be attached to openMRS.

Screenshots

image
image

@icrc-loliveira
Copy link
Contributor Author

@ibacher

@icrc-loliveira icrc-loliveira marked this pull request as ready for review January 17, 2024 11:10
ibacher
ibacher requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @icrc-loliveira!

packages/esm-patient-attachments-app/src/attachments/use-allowed-extensions.ts Outdated Show resolved Hide resolved
packages/esm-patient-attachments-app/src/attachments/use-allowed-extensions.ts Outdated Show resolved Hide resolved
packages/esm-patient-attachments-app/src/attachments/use-allowed-extensions.ts Outdated Show resolved Hide resolved
packages/esm-patient-attachments-app/src/camera-media-uploader/media-uploader.component.tsx Outdated Show resolved Hide resolved
packages/esm-patient-attachments-app/src/constants.ts Outdated Show resolved Hide resolved
@ibacher
Copy link
Member

ibacher commented Jan 26, 2024

@icrc-loliveira Could you look at the merge conflicts here? Should be a simple fix.

Luis Oliveira added 2 commits January 29, 2024 14:05
Merge branch 'main' of https://github.com/openmrs/openmrs-esm-patient…
aed1df9 
…-chart into 457330

# Conflicts:
#	packages/esm-patient-attachments-app/src/attachments/attachments-overview.component.tsx
PR review
657b640
ibacher
ibacher requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things. Has this been tested in a system without that global property set?

packages/esm-patient-attachments-app/src/attachments/attachments-overview.component.tsx Outdated Show resolved Hide resolved
packages/esm-patient-attachments-app/src/attachments/use-allowed-extensions.ts Outdated Show resolved Hide resolved
packages/esm-patient-attachments-app/src/attachments/use-allowed-extensions.ts Outdated Show resolved Hide resolved
@denniskigen denniskigen requested a review from ibacher January 30, 2024 18:02
@ibacher ibacher changed the title Attachments - Added configuration to the allowed file extension. (feat) Restrict attachments to configured allowed extensions Jan 30, 2024
@ibacher ibacher merged commit 6f81c47 into openmrs:main Jan 30, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request Mar 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icrc-loliveira @ibacher