-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-2662: Unable to attach images when registering/editing a patient #1585
Conversation
@jwnasambu @jwamalwa I tried to replicate your fixes locally, but the Screen.Recording.2024-01-16.at.11.57.08.PM.mov |
@Vijaykv5 you are right! I tried declaring the |
6ee1e5a
to
f838052
Compare
The expectation is that |
saveFile(file: UploadedFile) { | ||
setDataUri(file.base64Content); | ||
onCapturePhoto(file.base64Content, toOmrsIsoString(new Date())); | ||
close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saveFile(file: UploadedFile) {
setDataUri(file.base64Content);
onCapturePhoto(file.base64Content, toOmrsIsoString(new Date()));
close();
return Promise.resolve();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fix @jwnasambu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jwnasambu,I wanted to create a ticket for this but found its already beeing addressed here.
f838052
to
1a26d0b
Compare
Thanks @ibacher, @Vijaykv5 , @njiddasalifu thanks for the review. The issue is fixed. |
@ibacher May you can review this PR |
Requirements
Summary
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-2662
Other