(refactor) O3-2709: Update placeholder camera icon used in registration form

[psworld]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

In #1580 the icon that is used for image placeholder icon did not conform to the O3- style guidelines.
I changed the placeholder icon to use Camera Icon available at https://carbondesignsystem.com/guidelines/icons/library/ under Technology section and titled Camera

Screenshots

Before

After

Related Issue

https://openmrs.atlassian.net/browse/O3-2709

[denniskigen]

Thanks, @psworld!

[brandones]

Why didn't you just use the React component like we do with most of our icons? It's something like

import { Camera } from "@carbon/icons-react"

<Camera />

(but please refer to an actual usage in the codebase for the particulars).

[psworld]

Why didn't you just use the React component like we do with most of our icons? It's something like

import { Camera } from "@carbon/icons-react"

<Camera />

(but please refer to an actual usage in the codebase for the particulars).

placeholder.svg was being used for the icon, I though that's how it should be. But now I am realizing that the custom placeholder.svg was probably being used for the Grey Rectangular Box. I totally missed it !

I have made the changes and used <Camera /> component.

Could you please guide on how should I push changes ? as this branch is already merged

1. Should I force push changes on this same branch ? amend the last commit ?
2. Create a new branch and push changes there ?

[denniskigen]

Please create a new PR , @psworld. Thanks for catching this, @brandones.