Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-2755: Use snackbar notification in allergies app #1603

Merged
merged 1 commit into from
Jan 22, 2024
Merged

(feat) O3-2755: Use snackbar notification in allergies app #1603

merged 1 commit into from
Jan 22, 2024

Conversation

njiddasalifu
Copy link
Contributor

@njiddasalifu njiddasalifu commented Jan 21, 2024

Requirements

Summary

replacing toast notification to use new snackbar

Screenshots

Screenshot from 2024-01-21 09-00-15

Related Issue

https://openmrs.atlassian.net/browse/O3-2755

Copy link
Contributor Author

@njiddasalifu njiddasalifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @denniskigen @hadijahkyampeire kindly on your free time review this PR.

.gitignore Outdated Show resolved Hide resolved
@Vijaykv5
Copy link
Contributor

LGTM

Copy link
Member

@sherrif10 sherrif10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need import

"showToast"

?. You might want to fix issues related with CI

@njiddasalifu
Copy link
Contributor Author

Do you still need import

"showToast"

?. You might want to fix issues related with CI

thanks for the catch. We dont need the showToast again as its replaced by the showSnackbar which is consistent among other apps. What i am still having doubt is the fix to the failing tests in the CI.

@sherrif10
Copy link
Member

sherrif10 commented Jan 21, 2024

After making any change, First run this command yarn lint --fix to fix lint then run lint verify, then push again. i think this will fix CI

@njiddasalifu
Copy link
Contributor Author

thanks for the review @denniskigen, @sherrif10 and @Vijaykv5

@denniskigen denniskigen changed the title (feat) O3-2755: replacing toast notification to use new snackbar (feat) O3-2755: Use snackbar notification in allergies app Jan 22, 2024
@denniskigen
Copy link
Member

Thanks, @njiddasalifu.

@denniskigen denniskigen merged commit 7c62284 into openmrs:main Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants