-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-2755: Use snackbar notification in allergies app #1603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @denniskigen @hadijahkyampeire kindly on your free time review this PR.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need import
"showToast"
?. You might want to fix issues related with CI
thanks for the catch. We dont need the showToast again as its replaced by the showSnackbar which is consistent among other apps. What i am still having doubt is the fix to the failing tests in the CI. |
After making any change, First run this command yarn lint --fix to fix lint then run lint verify, then push again. i think this will fix CI |
packages/esm-patient-allergies-app/src/allergies/allergies-form/allergy-form.test.tsx
Outdated
Show resolved
Hide resolved
thanks for the review @denniskigen, @sherrif10 and @Vijaykv5 |
Thanks, @njiddasalifu. |
Requirements
Summary
replacing toast notification to use new snackbar
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-2755