-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-2757: Change all anchor tag cursors from text to pointer type. #1604
Conversation
Kindly share a full screen shot of the screen with in all other PRs, they dont look clear. |
before changesbefore.mp4after changesafter.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM .
packages/esm-patient-chart-app/src/patient-chart/chart-review/dashboard-view.scss
Outdated
Show resolved
Hide resolved
The right solution for this is not to add the pointer cursor, but instead to change the link to the Carbon Button (kind = ghost). The component is present here: openmrs-esm-patient-chart/packages/esm-patient-common-lib/src/empty-state/empty-state.component.tsx Line 33 in eb7dbec
|
@vasharma05 |
Hi @denniskigen @brandones ! P.S. 1st widget is the hover state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button implementation appears to conform to the designs. LGTM.
Requirements
Summary
The links on the empty state are replaced with Carbon buttons (kind = ghost).
Screenshots
before changes
after changes
Related Issue
https://openmrs.atlassian.net/jira/software/c/projects/O3/issues/O3-2757?filter=allopenissues