O3-2720: Visit stop time input not working in edit mode

[sherrif10]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

Ticket : https://openmrs.atlassian.net/browse/O3-2720

In the original code visitStartDate and visitStopDate are used to initialize the start and stop dates, respectively. If visitStartDate or visitStopDate is provided, they are used; otherwise, the current date is used. however the time-related fields visitStartTime, visitStartTimeFormat, visitStopTime, visitStopTimeFormat) are always initialized based on the provided or current date. in the fix i ensured consistency for both start and stop date. the code uses newDate() to get current date and time. Let me know your suggestions. cc @chibongho @rbuisson @vasharma05

www_screencapture_com_2024-1-26_01_01.mp4

After

[chibongho]

I don't think this fixes the underlying problem. This change seems to change the default start and end time in the form to current date / time. We still want to keep it defaulted to the original start / end time of the visit. The problem is with the minDate and maxDate calculation passed to the <DatePicker>

[sherrif10]

Hello @chibongho , i updated the code accordingly .

[sherrif10]

Hi @denniskigen .Looking forward to hear from you.

[denniskigen]

Hey, @sherrif10, thanks for working on this. Is the first video you linked to in the PR description meant to replicate the problem? I'm not sure that it does.

[denniskigen]

Some additional context on the minDate and maxDate props for Carbon datepickers:

DatePicker maxDate

Limits the date selection to any date before the date specified. The string format depends on the
locale specified. For example, the top example below is using the default US date format, and the
one below it is using the same format as the locale prop example. One is setting it as September
1st, and the other is setting it as January 9th.

DatePicker minDate

Works similarly to the maxDate prop.

[sherrif10]

Hello @denniskigen , Yes the first vedio is meant to replicate this issue.Are you suggesting i replace VisitDateTimeField with DatePicker for visit stop date while leveraging use of datePicker from carbon.

[denniskigen]

Why are we optionally calling new Date() here? It looks like its already getting called conditionally higher up when initializing defaultValues.

[sherrif10]

You are right , this pattern ensures that if visitToEdit doesn't have a start or stop datetime, the default value is set to the current date. The shared screen shot is the same.

[vasharma05]

Suggested change

	const visitStartDateValue = getValues('visitStartDate');
	const visitStartDate = visitStartDateValue !== undefined ? visitStartDateValue : new Date();
	const minVisitStopDatetimeFallback = Date.parse(visitStartDate.toLocaleString());
	minVisitStopDatetime = minVisitStopDatetime || minVisitStopDatetimeFallback;
	const visitStartDate = getValues('visitStartDate') ?? new Date();
	minVisitStopDatetime = minVisitStopDatetime ?? Date.parse(visitStartDate.toLocaleString());

Isn't this the whole change you did?

[sherrif10]

hI @vasharma05 ,Here is an updated screen shot

[sherrif10]

Hi @denniskigen @vasharma05 . i addressed your comments. let me know your suggestions.