(fix) Saving the medication should not send the dateActivated in the payload #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -48 B (0%) Total Size: 10.7 MB ℹ️ View Unchanged
|
AttoDeba1
approved these changes
Feb 2, 2024
|
@jayasanka-sack, this PR was meant to be in the release, as this was a major blocker for O3 users in Cambodia, since they were not able to sync their computers' time correctly, and hence wasn't even able to save the order. If you don't mind, can we take a patch release for this? I strongly push this PR in this release. |
|
Sure! |
jayasanka-sack
approved these changes
Feb 9, 2024
|
I went ahead and merged the PR to push for the release, but I'm wondering if we had a proper discussion before deciding to remove the field. |
|
Yes @jayasanka-sack! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Saving a medication should not send the
dateActivatedin the payload, since the request seems to be failing if the time in the user's computer is not synced properly.Screenshots
Screen.Recording.2024-02-01.at.15.07.16.mov
Related Issue
None
Other
None