(feat) O3-2779: Error messages in drug order form should be translated #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +27.9 kB (0%) Total Size: 10.7 MB
ℹ️ View Unchanged
|
denniskigen
changed the title
denniskigen
reviewed
Feb 9, 2024
Comment on lines
+69
to
+87
| dosage: z.number({ | ||
| invalid_type_error: translateFrom(moduleName, 'dosageRequiredErrorMessage', 'A dosage is required'), | ||
| }), | ||
|
|
||
| // t( 'selectUnitErrorMessage', 'Please select a unit' ) | ||
| unit: z.object( | ||
| { ...comboSchema }, | ||
| { | ||
| invalid_type_error: translateFrom(moduleName, 'selectUnitErrorMessage', 'Please select a unit'), | ||
| }, | ||
| ), | ||
|
|
||
| // t( 'selectRouteErrorMessage', 'Please select a route' ) | ||
| route: z.object( | ||
| { ...comboSchema }, | ||
| { | ||
| invalid_type_error: translateFrom(moduleName, 'selectRouteErrorMessage', 'Please select a route'), | ||
| }, | ||
| ), |
There was a problem hiding this comment.
Not directly related to your changes, but it appears that invalid_type_error is getting conflated with required_error here.
Per the Zod documentation, invalid_type_error is intended to customize the error message for type mismatches. This means it will trigger an error if the data types of the provided values do not align with those specified in the schema. So in this case, we'll expect to see the error if the provided content is not a string.
However, the current error messages suggest an intent to enforce the presence of these fields, which aligns more closely with the purpose of required_error.
denniskigen
approved these changes
Feb 9, 2024
|
Thanks, @vasharma05! We should probably document how to use |
denniskigen
reviewed
Feb 10, 2024
packages/esm-patient-medications-app/src/add-drug-order/drug-order-form.component.tsx
Show resolved
Hide resolved
Co-authored-by: Dennis Kigen <[email protected]>
This reverts commit d11523e.
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR allows translating the error messages in the drug order form. The Zod schema is defined outside a component/ hook, hence I used
translateFromto take care of the translations.Screenshots
None
Related Issue
https://issues.openmrs.org/browse/O3-2779
Other
None