Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Fix medications not loading when quantity unit property is null #1656

Merged
merged 1 commit into from
Feb 12, 2024
Merged

(fix) Fix medications not loading when quantity unit property is null #1656

merged 1 commit into from
Feb 12, 2024

Conversation

makombe
Copy link
Contributor

@makombe makombe commented Feb 12, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Before:
before

After:
after

Related Issue

Other

@makombe makombe force-pushed the error-showing-medications branch from c7ad712 to 80fbf51 Compare February 12, 2024 15:23
ojwanganto
ojwanganto approved these changes Feb 12, 2024
View reviewed changes
Copy link

@ojwanganto ojwanganto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

denniskigen
denniskigen approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @makombe!

@denniskigen denniskigen changed the title (fix):Fix error medication not loading when quantity unit is null (fix) Fix medications not loading when quantity unit property is null Feb 12, 2024
@denniskigen denniskigen merged commit 9c9ece8 into openmrs:main Feb 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@ojwanganto ojwanganto ojwanganto approved these changes

@donaldkibet donaldkibet Awaiting requested review from donaldkibet

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makombe @ojwanganto @denniskigen