(fix) O3-2867: Add required validation to the conditions form's condition field

[Twiineenock]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

Currently, when a user try to submit the conditions form without selecting a condition no form validation is displayed. Something like 'Please choose a condition' can be shown to the user.

Screenshots

before

after fix

Related Issue

https://openmrs.atlassian.net/browse/O3-2867

Other

attachments to issue
ConditionForm.webm

[ojwanganto]

I think we should just indicate that a condition is required to save the form. The error title is somehow misleading since at this point we haven't hit the backend.

[Twiineenock]

Thanks Antony, let me work on it in that line and would wait for your view about the changes

[hadijahkyampeire]

@Twiineenock these are so many files changed, try to rebase well.

[Twiineenock]

@hadijahkyampeire I repeated the rebasing I think I think they yarn file changed because of this command yarn up openmrs@next @openmrs/esm-framework@next then the translations changed because my changes of the error message in the conditions-form.component.tsx

[hadijahkyampeire]

@Twiineenock Yes the yarn lock changes after running yarn up, please always revert the changes after.

[denniskigen]

State of things following the commit I pushed:

conditions-validation.mp4

These changes:

• Ensure that the submit button is not disabled if mandatory fields are not filled
• Appends an asterisk to labels of mandatory fields to mark them as such

They are informed by this discussion on the ux-design-advisory channel.

[denniskigen]

A subsequent fix to this should mark the clinical status field as mandatory. This is to get in line with what the contract the backend provides https://hl7.org/fhir/condition.html#tx.

[denniskigen]

Thanks, @Twiineenock!

Changes implemented in subsequent commits