Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Upgrade peer-dependancy versions of single-spa and single-spa-react #1669

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

jayasanka-sack
Copy link
Member

@jayasanka-sack jayasanka-sack commented Feb 15, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Upgrade peer-dependancy versions as following

  • single-spa 6.x
  • single-spa-react 6.x

Screenshots

Related Issue

Other

@ibacher ibacher changed the title Upgrade peer-dependancy versions of single-spa and single-spa-react (chore) Upgrade peer-dependancy versions of single-spa and single-spa-react Feb 15, 2024
@jayasanka-sack
Copy link
Member Author

@ibacher Do we need to re-release beta 17?

@ibacher
Copy link
Member

ibacher commented Feb 15, 2024

@ibacher Do we need to re-release beta 17?

No such thing as a re-release. So we could add these in for -beta.18. I'm of the opinion that these are also non-blocking changes, though.

@ibacher ibacher merged commit 431b4e7 into openmrs:main Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants