Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-2604: Add a “refresh data“ button to the test results viewer #1671

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Feb 15, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I created a "Refresh Data" button on the far right section header. When clicked, the window.location.reload() method reloads the current page, effectively refreshing the content with new changes.

Screenshots

screencast.2024-02-16.1.AM-46-33.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-2604

Other

@jwnasambu jwnasambu changed the title (fix)o3 2604: add a “refresh data“ button to the test results viewer (fix)O3-2604: add a “refresh data“ button to the test results viewer Feb 15, 2024
@jwnasambu
Copy link
Contributor Author

@ibacher Kindly did you anticipate something like this?

@denniskigen denniskigen requested a review from ibacher February 16, 2024 20:36
@denniskigen denniskigen changed the title (fix)O3-2604: add a “refresh data“ button to the test results viewer (fix) O3-2604: Add a “refresh data“ button to the test results viewer Mar 26, 2024
@denniskigen
Copy link
Member

Latest commit just cleans up the UI a touch:

CleanShot 2024-03-26 at 1  32 50@2x

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jwnasambu. Is this the approach you envisaged, @ibacher?

@ibacher
Copy link
Member

ibacher commented Mar 27, 2024

LGTM. Thanks @jwnasambu!

@ibacher ibacher merged commit d9dd7f2 into openmrs:main Mar 27, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request May 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants