(feat) Add mode prop to React Form Engine component to handle different views #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10 B (0%) Total Size: 10.7 MB ℹ️ View Unchanged
|
arodidev
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Thanks @CynthiaKamau, I'm not sure whether including type in the import statement is necessary, otherwise this looks fine to me.
pirupius
changed the title
If i do not specify its a type eslint will shout |
pirupius
approved these changes
Feb 20, 2024
| @@ -1,7 +1,7 @@ | |||
| import React from 'react'; | |||
| import { useTranslation } from 'react-i18next'; | |||
| import { InlineLoading } from '@carbon/react'; | |||
| import { OHRIForm } from '@openmrs/openmrs-form-engine-lib'; | |||
| import { OHRIForm, type SessionMode } from '@openmrs/openmrs-form-engine-lib'; | |||
There was a problem hiding this comment.
@arodidev this is necessary because type annotations get removed when transpiling TS to JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The mode prop to OHRI form component will help in rendering different views eg read only view, edit view etc
Screenshots
Related Issue
Other