(chore) Remove timing env from lint script in all packages #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 10.7 MB ℹ️ View Unchanged
|
pirupius
approved these changes
Feb 20, 2024
|
Mind looking at this one too, @pirupius openmrs/openmrs-esm-patient-management#990 |
ibacher
reviewed
Feb 21, 2024
| @@ -12,7 +12,7 @@ | |||
| "debug": "npm run serve", | |||
| "build": "webpack --mode production --color", | |||
| "analyze": "webpack --mode=production --env analyze=true", | |||
| "lint": "cross-env TIMING=1 eslint src --ext tsx,ts --fix --max-warnings=0", | |||
| "lint": "cross-env eslint src --ext tsx,ts --fix --max-warnings=0", | |||
There was a problem hiding this comment.
We could drop the cross-env here too, since the only reason for that is to allow TIMING=1....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
I've removed the ESLint TIMING environment variable from the
lintscripts across all packages in this repo.Adding this variable used to be a recommendation for earlier versions of turbo (I can't find a link to where exactly in a past copy of the docs), but it has since been removed. This is likely because turbo caches logs to
stdoutandstderrby default. This means caching and parallelization should not be affected by this change.Screenshots
Related Issue
Other