Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) O3-2304: Hide side menu panel on item click #1693

Merged
merged 7 commits into from
Mar 3, 2024
Merged

(feat) O3-2304: Hide side menu panel on item click #1693

merged 7 commits into from
Mar 3, 2024

Conversation

usamaidrsk
Copy link
Member

@usamaidrsk usamaidrsk commented Feb 27, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds closing the side menu drawer when user clicks on an item

Screenshots

hide-side-menu-on-item-click.mp4

Related Issue

O3-2304

Other

@denniskigen
Copy link
Member

See openmrs/openmrs-esm-core#945 (comment).

@denniskigen
Copy link
Member

Also https://github.com/openmrs/openmrs-esm-core/pull/945/files/af44e0dc7cc1acf604568b4f32dadcb747d15753..f1eefaa7989282cb7499e47c05ccd1a5473e5837#r1507559880

denniskigen
denniskigen approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @usamaidrsk!

@denniskigen denniskigen merged commit e654f7f into openmrs:main Mar 3, 2024
6 checks passed
jnsereko pushed a commit to jnsereko/openmrs-esm-patient-chart that referenced this pull request Mar 4, 2024
@usamaidrsk @denniskigen @jnsereko
(feat) O3-2304: Hide side menu panel on item click (openmrs#1693)
eb96e79 
* feat: hide side menu panel on item click

* fix: remove untracked file

* fix: fix useEffect cleanup

* refactor: use popstate listener

* Fixup

---------

Co-authored-by: Dennis Kigen <[email protected]>
usamaidrsk added a commit to usamaidrsk/openmrs-esm-patient-chart that referenced this pull request Mar 11, 2024
@usamaidrsk @denniskigen
(feat) O3-2304: Hide side menu panel on item click (openmrs#1693)
59cd75f 
* feat: hide side menu panel on item click

* fix: remove untracked file

* fix: fix useEffect cleanup

* refactor: use popstate listener

* Fixup

---------

Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usamaidrsk @denniskigen