(fix) O3-2907: Always show order type filters in the order details table #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mccarthyaaron, thanks for the PR. I think the ideal approach here is moving the Dropdown filter out of the data tile, like so: dropdown-filters.mp4This change gets the UI/UX in line with the rest of the app. The other thing I'd recommend is customising the empty state tiles to reflect the related order type. So, |
denniskigen
changed the title
|
Thanks @denniskigen for the feedback. Let me work on it |
…isplay while still allowing user to switch between filters
- Spacing fixes for drug orders - Add expand all toggle to TableHeader
usamaidrsk
pushed a commit
to usamaidrsk/openmrs-esm-patient-chart
that referenced
this pull request
Mar 11, 2024
…ble (openmrs#1706) * Added an <EmptyData>-like component for when there are no orders to display while still allowing user to switch between filters * Take the filter component out of the data tile * display text for the EmptyState depends on the currently selected order type * Remove unused imports that were previously imported and used * Miscellaneous tweaks - Spacing fixes for drug orders - Add expand all toggle to TableHeader --------- Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Issue: When the user selects a filter(All, Drug Order, Test Order) and there are no entries to display for the given the filter, the
<EmptyState/>component is rendered which does not provide an option for the user to undo the filter and select another one.Suggested solution: Display the component that includes the filter in both cases i.e when there are entries to display and zero entries. With entries to display, show the and with zero entries display a UI that resembles the component but without the header part of it.
Screenshots
O3-2907.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-2907