(chore) Bump playwright #1715
(chore) Bump playwright #1715
Conversation
|
Please add a conventional commit label to your PR title. The appropriate one here is |
kdaud
changed the title
kdaud
force-pushed
the
Upping
branch
2 times, most recently
from
d1ab22d to
1c2682c
Compare
denniskigen
changed the title
|
@denniskigen we've a failing test in program-enrollment. I'm able to reproduce locally and will send a fix soon. |
|
Should I include the fix in this same commit or send a separate PR? |
|
Within the same PR |
|
@denniskigen I want to do some troubleshooting in GitHub actions but unfortunately the 'Re-run jobs' functionality is disabled from the user with id |
kdaud
force-pushed
the
Upping
branch
2 times, most recently
from
876a346 to
f4fdf30
Compare
|
Try again |
|
@denniskigen it seems like the latest playwright version is exposing an issue in one of the E2E test which could not be detected by the older version. |
|
I'm looking into the issue... |
There was a problem hiding this comment.
Thanks, @kdaud. There was a bug in the test where an assertion was checking for the wrong completion date.
…' for program enrollment
|
@denniskigen the latest playwright version runs the E2E tests faster. As a result the modified value for completion date gets overridden by the older value causing the test to fail at assertion level. So clearing the date fields before editing the dates resolves the issue. |
|
Excellent sleuthing work, @kdaud! Faster e2e execution is a great value add! |
* (chore) Bump playwright * Fixup - use correct completion date * Clear date fields before editing 'enrollmentDate' and 'completionDate' for program enrollment --------- Co-authored-by: Dennis Kigen <[email protected]>
Requirements
Summary
This PR upgrades playwright to the latest version 1.42.1. See release notes at https://playwright.dev/docs/release-notes
Screenshots
Related Issue
Other