(chore) Switch from lerna to yarn for publishing #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -317 kB (-3%) Total Size: 10.7 MB
ℹ️ View Unchanged
|
| @@ -84,7 +84,7 @@ jobs: | |||
| server-token: ${{ env.TURBO_TOKEN }} | |||
|
|
|||
| - name: Version | |||
| run: yarn lerna version "$(node -e "console.log(require('semver').inc(require('./lerna.json').version, 'patch'))")-pre.${{ github.run_number }}" --no-git-tag-version --no-push --yes | |||
| run: yarn workspaces foreach --worktree --topological version "$(node -e "console.log(require('semver').inc(require('./package.json').version, 'patch'))")-pre.${{ github.run_number }}" | |||
There was a problem hiding this comment.
We can exclude the root app here, right?
ex:
There was a problem hiding this comment.
No, because we want to version the @openmrs/esm-patient-chart-app package as well, right?
There was a problem hiding this comment.
@denniskigen The "root app" here is @openmrs/esm-patient-chart, i.e., the workspace package.json itself.
That said, as long as this works, I don't think it's wrong (the difference is, at most, a couple of milliseconds of execution time). If I did it again, I probably wouldn't write the patient-management CI script the same way; it would be nice to have symmetry between the command run here and the command used in the version script.
There was a problem hiding this comment.
Hmmm... there was a reason for the exclusion, it appears: https://github.com/openmrs/openmrs-esm-patient-chart/actions/runs/8189908003/job/22395772588
There was a problem hiding this comment.
I can push a PR to fix the exclusion.
If I did it again, I probably wouldn't write the patient-management CI script the same way; it would be nice to have symmetry between the command run here and the command used in the version script.
Should I change the command as well?
There was a problem hiding this comment.
So, actually, I think the pertinent place for the exclusion is in the ci:publish and ci:prepublish scripts in the package.json. It makes sense to add that here, I guess, for the same symmetry I was referring to.
ibacher
approved these changes
Mar 7, 2024
usamaidrsk
pushed a commit
to usamaidrsk/openmrs-esm-patient-chart
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR switches this repo from using lerna for publishing releases and pre-releases to using Yarn. This just brings this repo in line with others like Core and Patient Management that use Yarn for publishing.
Screenshots
Related Issue
Other