-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Update enrollment and discontinuation date to pick correct time zone #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
force-pushed
the
fix/programenrollment
branch
from
March 6, 2024 21:08
11bb909
to
3d531d6
Compare
Size Change: -511 kB (-5%) ✅ Total Size: 10.7 MB
ℹ️ View Unchanged
|
denniskigen
reviewed
Mar 7, 2024
packages/esm-form-entry-app/src/app/openmrs-api/program-resource.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/openmrs-api/program-resource.service.ts
Outdated
Show resolved
Hide resolved
donaldkibet
force-pushed
the
fix/programenrollment
branch
from
March 7, 2024 18:14
3d531d6
to
5a541a9
Compare
@denniskigen addressed the code review |
denniskigen
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Donald.
jecihjoy
approved these changes
Mar 7, 2024
denniskigen
changed the title
(feat) Update enrollment and discontinuation date to pick correct time zone.
(feat) Update enrollment and discontinuation date to pick correct time zone
Mar 7, 2024
usamaidrsk
pushed a commit
to usamaidrsk/openmrs-esm-patient-chart
that referenced
this pull request
Mar 11, 2024
…e zone. (openmrs#1719) * (fix) fix enroll and discontinue date on program enrollment to pick the correct timezone * (update) fix the submitted state to be last state change before closing form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR enhances the submit button, updating its state to 'submitted' post-action. Also, I've corrected timezone information for enrollment and discontinuation dates.
Screenshots
Related Issue
Other