(feat) O3-2647: Adds ability to add lab results and view within orders widget #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -147 kB (-1%) Total Size: 11 MB
ℹ️ View Unchanged
|
pirupius
changed the title
pirupius
changed the title
denniskigen
reviewed
Mar 18, 2024
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/lab-results/result-form-field.component.tsx
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/lab-results/lab-results-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/lab-results/lab-results-form.component.tsx
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/lab-results/lab-results-form.component.tsx
Outdated
Show resolved
Hide resolved
pirupius
force-pushed
the
feat/lab-results
branch
from
47c1924 to
14b2f07
Compare
samuelmale
reviewed
Mar 25, 2024
There was a problem hiding this comment.
I see most of the code relating to the Result Form, Result Form Fields along with their types very similar to the lab app implementation. @pirupius Can we find a way of sharing these components? Maybe expose the form as an extension? That way we won't have to offer maintenance twice.
cc: @ojwanganto @jabahum
|
In terms of just the types, getting them into strict alignment with others from elsewhere is probably not strictly necessary as a requirement to check this in, @samuelmale. It's worth ticketing that out. It's not often that work gets done at the edge where separate interfaces interact, so it's easy to forget to align things. |
|
Sure @denniskigen! I thought it's okay to start a conversation in that direction here.. of course it's not a showstopper for this unit. |
pirupius
force-pushed
the
feat/lab-results
branch
from
14b2f07 to
2b8c282
Compare
samuelmale
reviewed
Mar 25, 2024
packages/esm-patient-orders-app/src/lab-results/lab-results.resource.ts
Outdated
Show resolved
Hide resolved
samuelmale
reviewed
Mar 25, 2024
packages/esm-patient-orders-app/src/lab-results/lab-results.resource.ts
Outdated
Show resolved
Hide resolved
brandones
changed the title
pirupius
force-pushed
the
feat/lab-results
branch
from
2b8c282 to
791e13e
Compare
|
Mind adding a summary describing exactly what the PR changes, @pirupius? |
denniskigen
reviewed
Apr 2, 2024
packages/esm-patient-orders-app/src/lab-results/lab-results-form.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/lab-results/lab-results.resource.ts
Outdated
Show resolved
Hide resolved
ojwanganto
reviewed
Apr 3, 2024
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
Add test results from patient chart
pirupius
force-pushed
the
feat/lab-results
branch
from
4c6f947 to
35e5c66
Compare
|
@denniskigen all comments have been addressed apart from the ones that are involved with modifying orders which was out of scope for this PR. Will address tasks around modifying orders in a follow up and is being tracked by this ticket https://openmrs.atlassian.net/browse/O3-2813 |
denniskigen
reviewed
Apr 4, 2024
packages/esm-patient-orders-app/src/lab-results/lab-results-form.component.tsx
Outdated
Show resolved
Hide resolved
samuelmale
reviewed
Apr 5, 2024
packages/esm-patient-orders-app/src/lab-results/lab-results.resource.ts
Outdated
Show resolved
Hide resolved
|
Proceeding to merge this in. Hopefully all the outstanding concerns will get addressed in the ticket that @pirupius linked to above. |
denniskigen
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
results.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-2647
Other