(feat) re-use upcoming appointment work to mark appointments as Checked In
#1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Size Change: +1.39 kB (0%) Total Size: 10.8 MB ℹ️ View Unchanged
|
mseaton
reviewed
Mar 19, 2024
There was a problem hiding this comment.
I don't really know the background of this ticket, defer to @mogoodrich on that, but made a few comments within the PR.
| export function saveAppointment(appointment: AppointmentPayload, abortController: AbortController) { | ||
| return openmrsFetch(`${restBaseUrl}/appointment`, { | ||
| export const updateAppointmentStatus = async (toStatus: string, appointmentUuid: string) => { | ||
| const abortController = new AbortController(); |
There was a problem hiding this comment.
Previously this took in an abortController, now you are instantiating one. I think there is a useAbortController hook in esm-framework. Perhaps you are meant to use that? @ibacher / @denniskigen ?
| return openmrsFetch(`${restBaseUrl}/appointment`, { | ||
| export const updateAppointmentStatus = async (toStatus: string, appointmentUuid: string) => { | ||
| const abortController = new AbortController(); | ||
| const statusChangeTime = dayjs(new Date()).format(omrsDateFormat); |
There was a problem hiding this comment.
Do you really need to instanatiate and format the date? Can you not just submit a new Date() in the body?
There was a problem hiding this comment.
I do think you need to format the date into the OMRS date format, but you probably don't need to do the new Date(), ie you could just do dayjs().format(omrsDateFormat), but i might be wrong about that.
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
mogoodrich
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Generally looks good to me, though note @mseaton 's questions on the abort controller and comments about the "checked" text.
| return openmrsFetch(`${restBaseUrl}/appointment`, { | ||
| export const updateAppointmentStatus = async (toStatus: string, appointmentUuid: string) => { | ||
| const abortController = new AbortController(); | ||
| const statusChangeTime = dayjs(new Date()).format(omrsDateFormat); |
There was a problem hiding this comment.
I do think you need to format the date into the OMRS date format, but you probably don't need to do the new Date(), ie you could just do dayjs().format(omrsDateFormat), but i might be wrong about that.
donaldkibet
force-pushed
the
feat/checkingAppointments
branch
from
8ca8215 to
3d6ba9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
re-use upcoming appointment work to mark appointments as
Checked InScreenshots
Related Issue
Other