-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Various fixes for the visit notes form #1744
Conversation
Size Change: -125 kB (-1%) Total Size: 10.8 MB
ℹ️ View Unchanged
|
packages/esm-patient-notes-app/src/notes/visit-notes-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-notes-app/src/notes/visit-notes-form.component.tsx
Outdated
Show resolved
Hide resolved
2615e8c
to
8e6c33d
Compare
cffeee4
to
799b078
Compare
I have one more suggestion, but it should be verified with Ciaran. |
Is this good to go otherwise? @vasharma05 |
Yes @denniskigen |
Requirements
Summary
This PR fixes the various aspects of the visit notes form, including:
Fixing a deprecation in how observers are handled in the
fetchConceptDiagnosisByName
function (which I've renamedfetchDiagnosisConceptsByName
). I've elected to refactor the function to useopenmrsFetch
instead ofopenmrsObservableFetch
under the hood.Showing an error notification when there is a problem fetching diagnoses from the backend:
Rendering the diagnoses tags above the Primary diagnosis section so its clear that the diagnoses are not just linked to that section:
Screenshots
See above.
Related Issue
Other