fix (O3-2717): Form workspace shrinks when opened while on the Vitals & Biometrics page

[mccarthyaaron]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

This is a wacky solution which seems to work and I am hoping we can figure it out why and come up with a better one. Can walk you through my thought process as well if need be.

Screenshots

O3-2717.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-2717

[brandones]

Yeah why is it wacky and why does it work? Sorry, it's been a long time since I thought about the dashboard columns.

[Twiineenock]

@mccarthyaaron , did you find another way to get around this, otherwise it looks fine too me!

[Twiineenock]

@mccarthyaaron don't you think its a walk around?

[brandones]

@Twiineenock @mccarthyaaron Can one of you please explain why this is a wacky approach or a workaround? I'd like to understand this.

[mccarthyaaron]

@brandones @Twiineenock . I failed to get a valid reason as to why it works. But this is why I came up with the above solution. The issue only arises when looking at "vitals and biometrics" and when you inspect the elements, the only thing that really changes in all the different scenarios is the slot used. The "patient-chart-vitals-biometrics-dashboard-slot" has grid-template-columns: 1fr; with the children spanning 1 column each which should work. But then I tried changing it to grid-template-columns: 2fr; and have each child span 2 columns which worked. It is literally the same thing from a CSS point of view but one works and the other does not. Maybe it has something to do with the particular slot.

O3-2717.mp4

See attached video

[brandones]

Thanks for the explanation @mccarthyaaron , that makes sense! Well, your explanation makes sense, but yeah, the issue maybe doesn't 😆 . Nice job investigating and fixing, anyway.

[mccarthyaaron]

@brandones there is actually something small missing which is changing the "patient-chart-vitals-biometrics-dashboard-slot" to have 2 columns not the 1 column it currently has. Not sure exactly how to do that. It will be confusing for someone with no prior knowledge about this issue to see a grid container with 1 column whose children span 2 columns each