(fix) O3-2977: Make end date field editable for inactive conditions #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +447 B (0%) Total Size: 10.8 MB ℹ️ View Unchanged
|
denniskigen
requested review from
mogoodrich,
mseaton,
ibacher,
vasharma05 and
chibongho
hadijahkyampeire
approved these changes
Mar 21, 2024
denniskigen
changed the title
|
Thanks, @hadijahkyampeire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes it possible to modify the end date property of an existing condition when specified. Currently, the end date property in the update payload maps to an end date property in the FHIR Conditions resource. This property does not exist, however. The closest matching element is abatementDateTime, which is described as:
This PR renames the end date property in the Conditions payload to abatementDatetime, which gets things working as expected.
I've also made the following useful fixes:
launchConditionsFormcallback is invoked with an extra parameter,{ formContext: 'creating' }. This is required to get the condition name validation to work here. I've made this change in both the ConditionsOverview and ConditionsDetailedSummary components.searchproperty in the conditions form schema toconditionNameto reflect its purpose more accurately.current statusfield toclinical statusto get it in conformance with the FHIR Conditions spec.Screenshots
Before
endDateproperty.current-behaviour.mp4
After
after.mp4
Related Issue
O3-2977
Other