(fix) O3-2937: Make clinical status mandatory in the conditions form #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested review from
ibacher,
vasharma05,
dkayiwa,
jayasanka-sack,
mogoodrich and
brandones
and removed request for
ibacher
|
Size Change: -774 kB (-7%) ✅ Total Size: 11 MB
ℹ️ View Unchanged
|
ibacher
approved these changes
Mar 25, 2024
packages/esm-patient-conditions-app/src/conditions/conditions-widget.component.tsx
Outdated
Show resolved
Hide resolved
denniskigen
force-pushed
the
feat/mandatory-clinical-status
branch
from
2e88e3b to
5fda490
Compare
|
Thanks, @ibacher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Clinical statusshould be a mandatory field in the conditions form. The FHIR Conditions resource terminology bindings mark it as a required field. It also doesn't make much sense to record a condition without recording the status of the condition.This PR makes that possible by adding the necessary validation to the form so that an error gets shown when the form is submitted without providing a condition name and a clinical status.
Screenshots
mandatory-clinical-status.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-2937
Other
From the FHIR Condition resource elements,
Verification statusis another required field:Should we add this to the Conditions form?