Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-2627: Remove leading dot from allowedExtensions MIME types config #1780

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

icrc-loliveira
Copy link
Contributor

@icrc-loliveira icrc-loliveira commented Apr 8, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The 'attachments.allowedFileExtensions' property used to define the allowed extensions is also used by the attachments-module that is expecting the configuration to be with no dot on the extensions list.
So the goal of this PR is to remove the requirement of the dot.

  • Old: ['.jpeg', '.jpg', '.png', '.webp']
  • New: ['jpeg', 'jpg', 'png', 'webp']

This is a revert of this PR;
#1748

Screenshots

Related Issue

Other

@denniskigen denniskigen changed the title Remove the need of the '.' on the allowedExtensions configuration. (feat) O3-2627: Remove leading dot from allowedExtensions MIME types config Apr 8, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @icrc-loliveira!

@denniskigen denniskigen merged commit b9a1b64 into openmrs:main Apr 8, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request May 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants