(fix) O3-2813 disable test type edit when modifying lab orders #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
commented
Apr 9, 2024
| "@openmrs/esm-api@npm:5.5.1-pre.1659": | ||
| version: 5.5.1-pre.1659 | ||
| resolution: "@openmrs/esm-api@npm:5.5.1-pre.1659" | ||
| "@openmrs/esm-api@npm:5.5.1-pre.1685": |
There was a problem hiding this comment.
Updated framework because the previous version had an issue with overriding importmaps using the dev tools
pirupius
force-pushed
the
feat/O3-2813/actions-to-modify-orders
branch
from
fcb3a06 to
d3e11e1
Compare
|
Size Change: +75.1 kB (+1%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
samuelmale
approved these changes
Apr 10, 2024
| @@ -50,6 +46,7 @@ export function LabOrderForm({ | |||
| const { t } = useTranslation(); | |||
| const isTablet = useLayoutType() === 'tablet'; | |||
| const session = useSession(); | |||
| const [isEditing, setIsEditing] = useState(initialOrder && initialOrder.action === 'REVISE'); | |||
There was a problem hiding this comment.
Minor observation: The setter seems redundant maybe we just memoize the value?
const isEditing = useMemo(() => initialOrder && initialOrder.action === 'REVISE', [initialOrder]);
pirupius
force-pushed
the
feat/O3-2813/actions-to-modify-orders
branch
from
d3e11e1 to
901dcb2
Compare
|
Thanks @samuelmale @ojwanganto i've pushed the changes |
denniskigen
reviewed
Apr 10, 2024
| @@ -30,7 +30,7 @@ export default function AddLabOrderWorkspace({ | |||
| }: AddLabOrderWorkspace) { | |||
| const { t } = useTranslation(); | |||
|
|
|||
| const { patient, isLoading: isLoadingPatient } = usePatient(); | |||
| const { patient, isLoading: isLoadingPatient, patientUuid } = usePatient(); | |||
There was a problem hiding this comment.
All workspaces should receive the patientUuid prop implicitly. You shouldn't need to drill the prop down to LabOrderForm.
There was a problem hiding this comment.
Found a weird behaviour testing this that's why i added this change. Maybe it was a unique case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Disable changing test type when modifying an already existing order.
Other changes
Screenshots
Screen.Recording.2024-04-09.at.13.48.23.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-2813
Other